Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/metrics chart + comment/log cleanup #47

Merged
merged 6 commits into from
Aug 15, 2024
Merged

UI/metrics chart + comment/log cleanup #47

merged 6 commits into from
Aug 15, 2024

Conversation

bboinay
Copy link
Contributor

@bboinay bboinay commented Aug 15, 2024

No description provided.

@bboinay bboinay self-assigned this Aug 15, 2024
jjmchew
jjmchew approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@jjmchew jjmchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - I made a comment about the favicon which could be worth fixing before merging.

Otherwise, looks great.

ui/index.html Outdated Show resolved Hide resolved
ui/src/services/metric-service.ts Show resolved Hide resolved
@bboinay bboinay merged commit a5d5f4a into main Aug 15, 2024
0 of 3 checks passed
@bboinay bboinay deleted the ui/metrics-chart branch August 15, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjmchew jjmchew jjmchew approved these changes

@yg-lim yg-lim Awaiting requested review from yg-lim

@tlane25 tlane25 Awaiting requested review from tlane25

Assignees

@bboinay bboinay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bboinay @jjmchew